There’s a whole topic about this.
Short version: Those footprints with large plated through holes technically do not comply with JLCPCB capabilities but usually they do them anyway without comment. Usually, but sometimes they hold up the order for them. I have since switched to different footprints that specify unplated holes with vias.
I haven’t switched older design Gerbers to the newer footprints but the Hero’s popular enough that maybe I should.